On 22.08.2016 13:18, Oleg Fayans wrote:
ping for review
On 08/02/2016 01:11 PM, Oleg Fayans wrote:
I did! Thank you!
On 08/02/2016 12:31 PM, Martin Basti wrote:
On 01.08.2016 22:46, Oleg Fayans wrote:
The test was redesigned so that it actually tests against an AD user.
cleanly applies, passes lint and passes
Did you forget to send patches?
On 06/28/2016 01:40 PM, Oleg Fayans wrote:
Patch-0050 rebased against latest upstream branch
On 06/28/2016 10:45 AM, Oleg Fayans wrote:
Passing test output:
NACK for 0049.1
PEP8: you must use 2 empty lines between functions
+ new_args = " ".join(new_args + args)
you don't need this, run_command takes list as argument too
To make it more usable you should add raiseonerr as kwarg to
run_certutil (True as default)
NACK for 0050.2
+ tasks.run_certutil(master, ['-L', '-n', cls.adcert1, '-a', '>',
+ cls.adcert1_file], cls.reqdir)
+ tasks.run_certutil(master, ['-L', '-n', cls.adcert2, '-a', '>',
+ cls.adcert2_file], cls.reqdir)
IMO thus should raise an error if failed, but previously you set
raiseonerr=False (multiple times)
+ cls.ad = cls.ad_domains.ads
+ cls.ad_domain = cls.ad.domain.name
+ cls.aduser = "testuser@%s" % cls.ad_domain
+ cls.adcert1 = 'MyCert1'
+ cls.adcert2 = 'MyCert2'
+ cls.adcert1_file = cls.adcert1 + '.crt'
+ cls.adcert2_file = cls.adcert2 + '.crt'
New definitions of variables/constants should be directly in class not
in install method, adding new class variables in classmethod is the same
evil as adding instance variables outside __init__
I have question, why do you need AD for this test? AFAIK you can use ID
overrides without AD
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code