URL: https://github.com/freeipa/freeipa/pull/73
Title: #73: Tests for certificates with SAN

martbab commented:
NACK: you probably forgot to add service fixtures as params to the added test 
cases: https://paste.fedoraproject.org/437721/51355181/

In addition please write sensible commit message to commit f43833d and probably 
squash the last commit into 2d75883

I have also noticed that you linked the commits to a ticket in a already closed 
milestone. Per our process guidelines you need to open a new ticket and go 
through a new triage, sorry.

See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to