URL: https://github.com/freeipa/freeipa/pull/140
Title: #140: Tests: Remove invalid certplugin tests

pvomacka commented:
"""
I think that it is not good idea to remove tests, because we are lowering 
coverage. Therefore NACK. 

Could we rather rewrite these tests? For example issue certain certificates, 
revoke them and then test whether there are revoked certs with correct 
revocation reason. I think that our Tracker could help with it. 
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/140#issuecomment-251886076
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to