URL: https://github.com/freeipa/freeipa/pull/207
Author: Akasurde
 Title: #207: Provide user hint about IP address in IPA install
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/207/head:pr207
git checkout pr207
From 2fc9985c491f949d4fefedd0a2725f3419b2c01a Mon Sep 17 00:00:00 2001
From: Abhijeet Kasurde <akasu...@redhat.com>
Date: Wed, 2 Nov 2016 13:33:37 +0530
Subject: [PATCH] Provide user hint about IP address in IPA install

With this fix, user will be notified about pressing enter
to proceed with IPA installation procedure, if user has
provided valid IP address previously.

Fixes https://fedorahosted.org/freeipa/ticket/5949

Signed-off-by: Abhijeet Kasurde <akasu...@redhat.com>
---
 ipaserver/install/installutils.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/ipaserver/install/installutils.py b/ipaserver/install/installutils.py
index fb9579a..28980f7 100644
--- a/ipaserver/install/installutils.py
+++ b/ipaserver/install/installutils.py
@@ -267,9 +267,11 @@ def add_record_to_hosts(ip, host_name, conf_file=paths.HOSTS):
 
 def read_ip_addresses():
     ips = []
-    print("Enter the IP address to use, or press Enter to finish.")
+    msg_first = "Please provide the IP address to be used for this host name"
+    msg_other = "Enter an additional IP address, or press Enter to skip"
     while True:
-        ip = ipautil.user_input("Please provide the IP address to be used for this host name", allow_empty = True)
+        msg = msg_other if ips else msg_first
+        ip = ipautil.user_input(msg, allow_empty=True)
         if not ip:
             break
         try:
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to