URL: https://github.com/freeipa/freeipa/pull/235
Author: mbasti-rh
 Title: #235: Make Knob function deprecated
Action: opened

PR body:
"""
`Knob` function is outdated and was replaced by `knob`. Make explicit
note in code about this.

https://fedorahosted.org/freeipa/ticket/6392
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/235/head:pr235
git checkout pr235
From 292da31c7f18b4fcccb06a50909d45c17d76bdf9 Mon Sep 17 00:00:00 2001
From: Martin Basti <mba...@redhat.com>
Date: Fri, 11 Nov 2016 16:09:33 +0100
Subject: [PATCH] Make Knob function deprecated

`Knob` function is outdated and was replaced by `knob`. Make explicit
note in code about this.

https://fedorahosted.org/freeipa/ticket/6392
---
 ipapython/install/core.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ipapython/install/core.py b/ipapython/install/core.py
index f0b75e3..4199318 100644
--- a/ipapython/install/core.py
+++ b/ipapython/install/core.py
@@ -196,6 +196,10 @@ def Knob(type_or_base, default=_missing, sensitive=_missing,
          deprecated=_missing, description=_missing, cli_positional=False,
          cli_name=_missing, cli_short_name=_missing, cli_aliases=_missing,
          cli_metavar=_missing):
+    """
+    This function is deprecated and will be removed, please use `knob`
+    function instead (note lower case `k`)
+    """
     if isinstance(type_or_base, type) and issubclass(type_or_base, KnobBase):
         type_ = _missing
         bases = (type_or_base,)
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to