URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values

mirielka commented:
Having "None" default values for obligatory arguments does not seem to be a 
good idea. If the method was called with default values, it would fail. It 
would be best if obligatory arguments ("givenname" and "sn") were provided as 
positional arguments and voluntary "name" as keyword argument. Please note that 
such a change will cause failure of existing tests that use this tracker, 
therefore it's necessary to fix them as well - include this in separate commit 
of this PR. Also please don't forget to add testcases for which this PR was 
created originally - creating user without the "name" argument (both positive 
and negative testcases).

See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to