URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup

lslebodn commented:
Thank you very much for removing problematic patch. Do not forget to remove it 
from "Build phase 8" :-) as well

A) there are few conflicts => patch need to be rebased

B) I do not think that @tiran objection about rpm in makerpms.sh is valid but 
he should reply.

Otherwise ACK after rebase
Nice work and thank you very much for it.

BTW is there a plan to have "make dictcheck" functional?

See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to