URL: https://github.com/freeipa/freeipa/pull/223
Title: #223: LDAP refactoring: remove admin_conn

mbasti-rh commented:
"""
ACK: removing admin_conn connections
- just for future, python doesn't like to have too many dereference from 
performance point fo view. So you should in future use ldap = api.Backend.ldap2 
and then just use ldap.find_entries()
- it is not issue with this patch as it was done in this way before, but can be 
improved in future

NACK: upgrade commit
- you turned DS on earlier than it actually needs to be. In one of first steps 
of LDAP upgrade is DS turned off, so I don't see a reason for a such change
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/223#issuecomment-260899937
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to