URL: https://github.com/freeipa/freeipa/pull/312 Author: martbab Title: #312: bindinstance: use data in named.conf to determine configuration status Action: opened
PR body: """ Instead of checking sysrestore status which leads to incorrect evaluation of DNS configuration status during 4.2 -> 4.4 upgrade, look into named.conf to see whther it was already modified by IPA installer. https://fedorahosted.org/freeipa/ticket/6503 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/312/head:pr312 git checkout pr312
From 0e3e3dda5241ac4b3da707ac248fecbcf1155cef Mon Sep 17 00:00:00 2001 From: Martin Babinsky <mbabi...@redhat.com> Date: Tue, 6 Dec 2016 12:13:34 +0100 Subject: [PATCH] bindinstance: use data in named.conf to determine configuration status Instead of checking sysrestore status which leads to incorrect evaluation of DNS configuration status during 4.2 -> 4.4 upgrade, look into named.conf to see whther it was already modified by IPA installer. https://fedorahosted.org/freeipa/ticket/6503 --- ipaserver/install/bindinstance.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ipaserver/install/bindinstance.py b/ipaserver/install/bindinstance.py index 5c3bdac..7aa9ed4 100644 --- a/ipaserver/install/bindinstance.py +++ b/ipaserver/install/bindinstance.py @@ -1171,6 +1171,13 @@ def check_global_configuration(self): self.api.Command.dnsconfig_show.output_for_cli(textui, result, None, reverse=False) + def is_configured(self): + """ + Override the default logic querying StateFile for configuration status + and look whether named.conf was already modified by IPA installer. + """ + return named_conf_exists() + def uninstall(self): if self.is_configured(): self.print_msg("Unconfiguring %s" % self.service_name)
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
