Moved to PR: https://github.com/freeipa/freeipa/pull/327
On 11/10/2016 07:47 PM, Petr Vobornik wrote:
On 08/09/2016 01:29 PM, Pavel Vomacka wrote:
please review attached patches.
The rpc module is now separated from display layer
and changing activity text while loading metadata.
Looks good, works fine, it just needed rebase(I could provide that).
Idea, but that doesn't have to be implemented, or sometime in future,
right now it is not useful: What about providing the rpc object in the
event, and having unique id for each rpc call so that we could track all
rpc which are executed.
1. It's event name but the property name looks like that it contains a text:
that.change_text = 'change-activity-text';
Should it be rather: that.change_text_event.
Or even, why does it compare previous text? Does it matter? Wouldn't be
better to have 'set-activity' event. And then the handler would call
something new set_text method:
that.dots = 0
that.text = new_activity
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code