URL: https://github.com/freeipa/freeipa/pull/328 Author: mbasti-rh Title: #328: fix: regression in API version comparison Action: opened
PR body: """ Commint 2cbaf156045769b54150e4d4c3c1071f164a16fb introduced a regression in API version comparison. In case that newer client is trying to call older server an error is returned, but it should work. This commit fixes it. https://fedorahosted.org/freeipa/ticket/6468 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/328/head:pr328 git checkout pr328
From 36dfd4524acb3d3ab595c3ea126035f8781a451f Mon Sep 17 00:00:00 2001 From: Martin Basti <mba...@redhat.com> Date: Mon, 12 Dec 2016 18:28:53 +0100 Subject: [PATCH] fix: regression in API version comparison Commint 2cbaf156045769b54150e4d4c3c1071f164a16fb introduced a regression in API version comparison. In case that newer client is trying to call older server an error is returned, but it should work. This commit fixes it. https://fedorahosted.org/freeipa/ticket/6468 --- ipalib/frontend.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ipalib/frontend.py b/ipalib/frontend.py index dfa6cdf..41dcd4a 100644 --- a/ipalib/frontend.py +++ b/ipalib/frontend.py @@ -776,8 +776,7 @@ def verify_client_version(self, client_version): sver=self.api_version, server=self.env.xmlrpc_uri) - if (client_apiver.major != server_apiver.major - or client_apiver > server_apiver): + if client_apiver.major != server_apiver.major: raise VersionError(cver=client_version, sver=self.api_version, server=self.env.xmlrpc_uri)
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
