URL: https://github.com/freeipa/freeipa/pull/419
Author: HonzaCholasta
 Title: #419: ipa-ca-install: do not fail without --subject-base and 
--ca-subject
Action: opened

PR body:
"""
When --subject-base and --ca-subject are not specified in ipa-ca-install,
default values are used. DN objects are used as the default values in
ipa-ca-install, but the CA installer expects the values to be strings. This
causes ipa-ca-install to fail unless both --subject-base and --ca-subject
are specified.

Convert the DN objects to strings to fix the issue.

https://fedorahosted.org/freeipa/ticket/2614
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/419/head:pr419
git checkout pr419
From ebe74e003505c857003114281580fd439e1c7648 Mon Sep 17 00:00:00 2001
From: Jan Cholasta <jchol...@redhat.com>
Date: Mon, 30 Jan 2017 13:25:04 +0100
Subject: [PATCH] ipa-ca-install: do not fail without --subject-base and
 --ca-subject

When --subject-base and --ca-subject are not specified in ipa-ca-install,
default values are used. DN objects are used as the default values in
ipa-ca-install, but the CA installer expects the values to be strings. This
causes ipa-ca-install to fail unless both --subject-base and --ca-subject
are specified.

Convert the DN objects to strings to fix the issue.

https://fedorahosted.org/freeipa/ticket/2614
---
 install/tools/ipa-ca-install | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/install/tools/ipa-ca-install b/install/tools/ipa-ca-install
index 0952d00..5e425f8 100755
--- a/install/tools/ipa-ca-install
+++ b/install/tools/ipa-ca-install
@@ -216,10 +216,11 @@ def install_master(safe_options, options):
     options.host_name = api.env.host
 
     if not options.subject_base:
-        options.subject_base = installutils.default_subject_base(api.env.realm)
+        options.subject_base = str(
+            installutils.default_subject_base(api.env.realm))
     if not options.ca_subject:
-        options.ca_subject = installutils.default_ca_subject_dn(
-            options.subject_base)
+        options.ca_subject = str(
+            installutils.default_ca_subject_dn(options.subject_base))
 
     try:
         ca.subject_validator(ca.VALID_SUBJECT_BASE_ATTRS, options.subject_base)
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to