URL: https://github.com/freeipa/freeipa/pull/416
Title: #416: replica install: relax domain level check for promotion

stlaz commented:
The purpose of `check_domain_level()` was to have a unified means of checking 
whether the domain level in the rest of the domain corresponds to the 
installation media which is presented by the user. 

Looking back at it I think I chose poor naming and documentation of the check 
so it's rather confusing.
If you find a way to make a unified check in both domain levels (=> a single 
function call for both DLs that will raise exception when wrong installation 
media is presented), that'd be nice. Otherwise feel free to split it back to 
what it was previously.

See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to