URL: https://github.com/freeipa/freeipa/pull/444
Title: #444: Allow nsaccountlock to be searched in user-find commands

HonzaCholasta commented:
Replacing `flags=['no_option']` with `flags=['no_create', 'no_update']` is not 
backward compatible - the `no_option` flag only hides the option in the CLI, 
but `no_create` / `no_update` would completely remove it from `user_add` / 

So, @redhatrises's approach is OK, although I would rather remove the 
`no_option` flag in `user.takes_options` and add it back in 
`user_add.get_options()` and `user_mod.get_options()`.

Also, now that the options is visible in CLI, you should set 
`cli_name='disabled'` on it, so that we have a `--disabled` option rather than 
`--nsaccountlock` option in `ipa user-find`.

See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to