URL: https://github.com/freeipa/freeipa/pull/540 Author: frasertweedale Title: #540: rabase.get_certificate: make serial number arg mandatory Action: opened
PR body: """ In rabase.get_certificate it does not make sense for the serial_number argument to be optional. Make it a mandatory positional argument. Part of: https://pagure.io/freeipa/issue/3473 Part of: https://pagure.io/freeipa/issue/5011 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/540/head:pr540 git checkout pr540
From 96f1df7cca67e411ac0768cdbd1be6fbc0e87b57 Mon Sep 17 00:00:00 2001 From: Fraser Tweedale <ftwee...@redhat.com> Date: Mon, 6 Mar 2017 12:50:55 +1000 Subject: [PATCH] rabase.get_certificate: make serial number arg mandatory In rabase.get_certificate it does not make sense for the serial_number argument to be optional. Make it a mandatory positional argument. Part of: https://pagure.io/freeipa/issue/3473 Part of: https://pagure.io/freeipa/issue/5011 --- ipaserver/plugins/dogtag.py | 2 +- ipaserver/plugins/rabase.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ipaserver/plugins/dogtag.py b/ipaserver/plugins/dogtag.py index 80d499e..05b759d 100644 --- a/ipaserver/plugins/dogtag.py +++ b/ipaserver/plugins/dogtag.py @@ -1502,7 +1502,7 @@ def check_request_status(self, request_id): return cmd_result - def get_certificate(self, serial_number=None): + def get_certificate(self, serial_number): """ Retrieve an existing certificate. diff --git a/ipaserver/plugins/rabase.py b/ipaserver/plugins/rabase.py index 49a3f8b..0c8d7e2 100644 --- a/ipaserver/plugins/rabase.py +++ b/ipaserver/plugins/rabase.py @@ -59,7 +59,7 @@ def check_request_status(self, request_id): """ raise errors.NotImplementedError(name='%s.check_request_status' % self.name) - def get_certificate(self, serial_number=None): + def get_certificate(self, serial_number): """ Retrieve an existing certificate.
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
