URL: https://github.com/freeipa/freeipa/pull/578
Title: #578: Coverity: fix bad use of null-like value in cert.py

tomaskrizek commented:
"""
Sorry about the link, I've removed it.

Nevertheless, it seems that's indeed a false positive, because `principal_type` 
is set to `USER`, but `principal_type == KRBTGT` on 
[L616](https://github.com/freeipa/freeipa/pull/578/files#diff-95cc6f5739d8923e9d470c2f686038f1R616)
 is evaluated as true instead of `principal_type == USER` at 
[L624](https://github.com/freeipa/freeipa/pull/578/files#diff-95cc6f5739d8923e9d470c2f686038f1R624)
 which would set `principal_obj`. There is no other assignment to 
`principal_type` in between.

Closing the PR, coverity error is a false positive.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/578#issuecomment-286355703
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to