URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata

rcritten commented:
You are duplicating the list of helpers. It would have been better to have 
helper defined as a StrEnum. If it isn't too late to change (e.g. no release 
has shipped with that in the API) then perhaps a separate patch, then you 
wouldn't need this enforcement at all.

See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to