URL: https://github.com/freeipa/bind-dyndb-ldap/pull/11
Title: #11: Coverity: fix REVERSE_INULL for pevent->inst

pemensik commented:
Hi Tomáš,

I did not find any place which could result with inst == NULL. 
ldap_sync_prepare contains proper REQUIRE(inst != null) and all other function 
uses its result stored in ls_private. I think null check does not harm 
anything. It is used in BIND to catch unexpected problems after code changes. I 
would suggest to place one require at the beginning of syncrepl_update function 

Overall I think it should be merged.

See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to