URL: https://github.com/freeipa/freeipa/pull/681 Title: #681: Fix ipadiscovery
martbab commented: """ Hi Alex, a few comments: 1.) please see PEP8 guide for correct Python formatting https://www.python.org/dev/peps/pep-0008/ namely, do not use tabs but 4 spaces for indentation. 2.) I do not see much value in sorting TXT records. We are searching for _kerberos TXT record which should occur only once in DNS domain. 3.) please use a more concise sorting mechanism mentioned by @tiran, your way is very unpythonic and inefficient (list insertions). """ See the full comment at https://github.com/freeipa/freeipa/pull/681#issuecomment-291064621
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
