URL: https://github.com/freeipa/freeipa/pull/786
Author: flo-renaud
 Title: #786: ipa-server-install: fix uninstall
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/786/head:pr786
git checkout pr786
From 5545ef33c21ed593cef2ff042b3b543e0c4b1945 Mon Sep 17 00:00:00 2001
From: Florence Blanc-Renaud <f...@redhat.com>
Date: Mon, 15 May 2017 16:36:44 +0200
Subject: [PATCH] ipa-server-install: fix uninstall

ipa-server-install --uninstall fails to stop tracking the certificates
because it assigns a tuple to the variable nicknames, then tries to
call nicknames.append(). This is a regression introduced by 21f4cbf8.

Assignment should be done using nicknames = list(self.tracking_reqs) instead.

 ipaserver/install/dogtaginstance.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaserver/install/dogtaginstance.py b/ipaserver/install/dogtaginstance.py
index 29c74b6..1fdc3e5 100644
--- a/ipaserver/install/dogtaginstance.py
+++ b/ipaserver/install/dogtaginstance.py
@@ -319,7 +319,7 @@ def stop_tracking_certificates(self, stop_certmonger=True):
-        nicknames = self.tracking_reqs
+        nicknames = list(self.tracking_reqs)
         if self.server_cert_name is not None:
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to