On Fri, 2007-05-04 at 16:38 -0600, Levi Pearson wrote:
> On Fri, 2007-05-04 at 14:41 -0700, Al Chu wrote:
> > just added two docs, comments are welcome:
> > 
> > doc/freeipmi-coding.txt - coding style intro, explanation of coding
> > decisions done in libfreeipmi.
> I like it so far, though it doesn't seem to address some of the issues
> that you found in my initial patch submissions, such as sanity checking
> of parameters for nulls and lengths.  I'm not sure if those are within
> the intended scope of the document or not.

Probably should, thanks :-)

> One question I've been meaning to ask is regarding tabs vs. spaces.
> While trying to emulate the style of the surrounding code I was working
> on, I noticed that sometimes tabs are expanded to spaces and sometimes
> they're not.  Is there a standard for the project?

Not yet that I know of.  We should probably standardize :-)

> I also want to say that I really like the fiid structure and associated
> macros and functions, though it took me a little while to figure them
> out.  

Thanks.  That's partially why I wrote that section in the coding doc.
It's not the normal approach, so I know a lot of programmers would look
strangely at it.  I've had to defend it several times to other
programmers in my own hallway by explaining to them why the IPMI
protocol is different.

> I'm a little sad that the scheme interpreter was deprecated and
> removed, too. 

I think you're in the minority :-)  It was just too hard to support and
get community involvement since 99% of CS-folk don't know scheme.

I always say, "if you've taken CS 101, you can debug w/ a printf".  But
without printfs in Scheme ... a lot of people were stuck.


> > 
> > doc/freeipmi-hostrange.txt - describes using the new hostrange support
> > in freeipmi.
> > 
> This looks very nice.  I'm going to have to look at it in more depth,
> but it looks like another big step in cluster usability over ipmitool,
> which we've been using.  I may have some more comments later after I get
> a chance to play with the pdsh-like features.
>               --Levi
Albert Chu
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

Freeipmi-devel mailing list

Reply via email to