Hey Kenneth,

Doh!  I didn't fall through on a error case correctly.  Does the
attached patch fix the problem?

cd freeipmi-0-8-9/
patch -p0 < fallthrough.patch

Al

On Mon, 2010-09-13 at 05:09 -0700, Kenneth Stailey wrote:
> 
> $ sudo /opt/freeipmi/sbin/ipmi-sensors
> ipmi-openipmi-driver.c: 379: ipmi_openipmi_ctx_io_init: errno '' (2)
> ipmi-api.c: 1004: ipmi_ctx_open_inband: error 'device not found' (5)
> ipmi-sunbmc-driver.c: 330: ipmi_sunbmc_ctx_io_init: errno '' (2)
> ipmi-api.c: 1031: ipmi_ctx_open_inband: error 'device not found' (5)
> ipmi-api.c: 849: ipmi_ctx_open_inband: error 'device not supported' (17)
> ipmi-locate-dmidecode.c: 562: ipmi_locate_dmidecode_get_device_info: error 
> 'internal system error' (6)
> ipmi-locate-smbios.c: 411: _copy_ipmi_dev_info: error 'internal system error' 
> (6)
> ipmi-locate-pci.c: 301: ipmi_locate_pci_get_device_info: error 'internal 
> system error' (6)
> ipmi-locate.c: 161: _ipmi_locate_get_device_info: error 'internal system 
> error' (6)
> ipmi-api.c: 778: ipmi_ctx_open_inband: error 'device already open' (15)
> ipmi_ctx_find_inband: device already open
> 
> --- On Fri, 9/10/10, Albert Chu <[email protected]> wrote:
> 
> > From: Albert Chu <[email protected]>
> > Subject: Re: [Freeipmi-devel] ipmi_ctx_find_inband: device already open
> > To: "Kenneth Stailey" <[email protected]>
> > Cc: "[email protected]" <[email protected]>
> > Date: Friday, September 10, 2010, 5:28 PM
> > Hey Kenneth,
> > 
> > I looked through to code to see what might possibly cause
> > this, but I
> > can't find anything.  Do you think you could download
> > the .tar.gz and
> > compile with debugging to get me some extra info?  To
> > compile w/
> > debugging, specify --enable-debug and --enable-trace in
> > ./configure.
> > 
> > Thanks,
> > Al
> > 
> > On Fri, 2010-09-10 at 12:57 -0700, Kenneth Stailey wrote:
> > > $ lsb_release -d
> > > Description:    Ubuntu 8.04.4 LTS
> > > 
> > > $ uname -srv
> > > Linux 2.6.24-28-server #1 SMP Wed Aug 25 14:46:03 UTC
> > 2010
> > > 
> > > $ echo `sudo dmidecode -s system-manufacturer ; sudo
> > dmidecode -s system-product-name`
> > > HP ProLiant DL145 G1
> > > 
> > > $ sudo ipmi-sensors --version
> > > ipmi-sensors - 0.8.9
> > > Copyright (C) 2003-2010 FreeIPMI Core Team
> > > This program is free software; you may redistribute it
> > under the terms of
> > > the GNU General Public License.  This program has
> > absolutely no warranty.
> > > 
> > > $ sudo ipmi-sensors
> > > ipmi_ctx_find_inband: device already open
> > > 
> > > Please help, thanks.
> > > 
> > > 
> > > _______________________________________________
> > > Freeipmi-devel mailing list
> > > [email protected]
> > > http://**lists.gnu.org/mailman/listinfo/freeipmi-devel
> > > 
> > -- 
> > Albert Chu
> > [email protected]
> > Computer Scientist
> > High Performance Systems Division
> > Lawrence Livermore National Laboratory
> > 
> > 
> 
-- 
Albert Chu
[email protected]
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory
Index: libfreeipmi/src/api/ipmi-api.c
===================================================================
--- libfreeipmi/src/api/ipmi-api.c	(revision 7346)
+++ libfreeipmi/src/api/ipmi-api.c	(revision 7347)
@@ -847,7 +847,7 @@
       if (locate_info.address_space_id != IPMI_ADDRESS_SPACE_ID_SYSTEM_IO)
         {
           API_SET_ERRNUM (ctx, IPMI_ERR_DEVICE_NOT_SUPPORTED);
-          return (-1);
+          goto cleanup;
         }
 
       if (!(ctx->io.inband.kcs_ctx = ipmi_kcs_ctx_create ()))
_______________________________________________
Freeipmi-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/freeipmi-devel

Reply via email to