On Mon, 2016-01-04 at 12:06 -0800, Albert Chu wrote: > Hey Charles, > > I think the patch is fine. But now that the unit files don't check > for /dev/ipmi*, shouldn't they be named without the "/dev/ipmi"??
Err, I mean named without the "dev-ipmi.service"? Al > > Al > > On Wed, 2015-12-30 at 14:06 -0600, charles_r...@dell.com wrote: > > Include systemd units that send OS start and shutdown events. > > > > Signed-off-by: Charles Rose <charles_r...@dell.com> > > --- > > Changes from v1: > > - Renamed systemd unit files to be more meaningful. > > - Removed check Condition for /dev/ipmi* > > - Removed Makefile defaults. Post acceptance of this patch, I will submit > > a separate patch that creates a sub-package containing these units. > > > > etc/os-shutdown-event-dev-ipmi.service | 17 +++++++++++++++++ > > etc/os-startup-event-dev-ipmi.service | 16 ++++++++++++++++ > > 2 files changed, 33 insertions(+) > > create mode 100644 etc/os-shutdown-event-dev-ipmi.service > > create mode 100644 etc/os-startup-event-dev-ipmi.service > > > > diff --git a/etc/os-shutdown-event-dev-ipmi.service > > b/etc/os-shutdown-event-dev-ipmi.service > > new file mode 100644 > > index 0000000..99fc7ce > > --- /dev/null > > +++ b/etc/os-shutdown-event-dev-ipmi.service > > @@ -0,0 +1,17 @@ > > +[Unit] > > +Description=Send OS shutdown event to BMC > > +Documentation=man:bmc-device > > +RefuseManualStart=true > > +DefaultDependencies=no > > +Before=shutdown.target > > +ConditionFileIsExecutable=/usr/sbin/bmc-device > > + > > +[Service] > > +Type=oneshot > > +# IPMI v2.0 rev 1.1 Table 42-3. > > +# OS Stop / Shutdown: 0x20; "OS Graceful Shutdown": 0x03 > > +Environment="STOP_EVENT=0x41 0x04 0x20 0x01 0x6f assertion 0x03 0x00 0x00" > > +ExecStart=/usr/sbin/bmc-device --platform-event=${STOP_EVENT} > > + > > +[Install] > > +WantedBy=shutdown.target > > diff --git a/etc/os-startup-event-dev-ipmi.service > > b/etc/os-startup-event-dev-ipmi.service > > new file mode 100644 > > index 0000000..7546dfa > > --- /dev/null > > +++ b/etc/os-startup-event-dev-ipmi.service > > @@ -0,0 +1,16 @@ > > +[Unit] > > +Description=Send OS startup event to BMC > > +Documentation=man:bmc-device > > +RefuseManualStart=true > > +ConditionFileIsExecutable=/usr/sbin/bmc-device > > + > > +[Service] > > +Type=oneshot > > +# IPMI v2.0 rev 1.1 Table 42-3. > > +# Base OS Boot/Installation Status: 0x1f; "C: boot completed": 0x01 > > +Environment="START_EVENT=0x41 0x04 0x1f 0x01 0x6f assertion 0x01 0x00 0x00" > > +ExecStart=/usr/sbin/bmc-device --platform-event=${START_EVENT} > > + > > +[Install] > > +WantedBy=basic.target > > +Also=os-shutdown-event-dev-ipmi.service -- Albert Chu ch...@llnl.gov Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory _______________________________________________ Freeipmi-devel mailing list Freeipmi-devel@gnu.org https://lists.gnu.org/mailman/listinfo/freeipmi-devel