> * The ModeController.createMap method seems to be static, since it takes > ModeController object as a parameter (although not shown so in the > diagram). But interfaces cannot have static methods.
You are right, I have not considered the method to be static and I should remove the parameter. > * ModeController also have saveMap/loadMap methods. Do you expect these > methods to have different implementations in different mode controllers? > Otherwise wouldn't it be better to make them static methods of some > separate, globally accessible class? Yes, for instance freemind now has a so-called file mode where file system is shown and can be navigated as a mind map, but there is no legal "save" operation. > * There are 4 different Observer classes shown on the same page. It does > not seem to mention which class has the "add*Observer" methods. In case > ModeController was intended, doesn't it seem unusual that someone trying > to listen for such events would be required to register the listener to > every single active ModeController implementation? Once again, it does > seem like firing/managing such listeners could be done from a separate, > globally accessible object. I have in mind that the extensions added to the mode controller (as it is an ExtensionCollection) could automatically become the listener if they implement the required interfaces. The reason for it is that the extensions of the mode controller are property controller responsible for creating/loading/saving/deleting of the property objects. Dimitry ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Freemind-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freemind-developer
