Hi Dan, your fix has been introduced into CVS.
Please choose the correct branch to review the changes. For example here: http://freemind.cvs.sourceforge.net/viewvc/freemind/freemind/freemind/modes/common/actions/?pathrev=fm_060405_integration Best regards, Chris Am 25.10.10 09:30, schrieb Dan Polansky: > Hello Chris, > > I cannot find any change in CVS in FindAction.java, so I cannot > directly review the code: > > http://freemind.cvs.sourceforge.net/viewvc/freemind/freemind/freemind/modes/actions/FindAction.java?view=log > > Is the change in CVS? Am I looking at a wrong place? > > The main thing: The fix has to look as follows, so that the conversion > to lowercase takes place only after the unicode entity characters have > been unescaped: > > String nodeText = node.toString(); > if (HtmlTools.isHtmlNode(nodeText)) { > nodeText = HtmlTools.unescapeHTMLUnicodeEntity(nodeText); > nodeText = HtmlTools.removeHtmlTagsFromString(nodeText); > } > if(!caseSensitive) { > nodeText = nodeText.toLowerCase(); > } > > This is my mistake. The way I have originally described it in the bug > report was wrong; sorry for that. Thanks to user socratesf for > pointing out that the conversion to lowercase needs to take place at > the very end. > > Best regards, > Dan > > > On Sun, Oct 24, 2010 at 7:37 PM, Christian Foltin (GMX) > <[email protected]> wrote: >> Hi Dan, >> >> ad 15: I did, was I extracted from the posts: >> >> String nodeText = caseSensitive ? >> node.toString() : node.toString() >> .toLowerCase(); >> // Bug fix for >> http://sourceforge.net/tracker/?func=detail&aid=3035387&group_id=7118&atid=107118 >> if (HtmlTools.isHtmlNode(nodeText)) { >> nodeText = >> HtmlTools.unescapeHTMLUnicodeEntity(nodeText); >> } >> nodeText = >> HtmlTools.removeHtmlTagsFromString(nodeText); >> // End bug fix. >> >> What's wrong with it? It worked for german umlauts, which couldn't be >> found before. >> >> Best regards, Chris >> >> Am 22.10.10 14:40, schrieb Dan Polansky: >>> Hello Chris, >>> >>> I have tested the released 0.9.0 RC10. I have marked three bugs as fixed: >>> >>> 12. data loss in notes; note conversion >>> >>> 13. Conversion from 0.8.0 to 0.9.0 drops newlines in notes >>> >>> 17. Export to Twiki - bulleted list >>> >>> In the release notes of 0.9.0 RC10, you write that you have also fixed >>> the bug with searching for the Greek text. My testing shows the bug as >>> non-fixed; it is still there, reproducible using the mind map attached >>> to the bug report. >>> >>> 15. Freemind cannot find text with Greek characters >>> http://sourceforge.net/tracker/?func=detail&aid=3035387&group_id=7118&atid=107118 >>> >>> I am keeping a list of open bugs here: >>> >>> http://freemind.sourceforge.net/wiki/index.php/Finishing_0.9.0 >>> >>> Best regards, >>> Dan > > ------------------------------------------------------------------------------ > Nokia and AT&T present the 2010 Calling All Innovators-North America contest > Create new apps& games for the Nokia N8 for consumers in U.S. and Canada > $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing > Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store > http://p.sf.net/sfu/nokia-dev2dev > _______________________________________________ > Freemind-developer mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freemind-developer ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Freemind-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freemind-developer
