>I'd prefer not to have the assumption DS == ES == FS == GS 
>hardcoded into the kernel :-/   Please treat all segment
>registers separately.
Ok.

>Not really.  'cs' points to some descriptor that has just been regenerated
>from the guest GDT;  there's no point in modifying it ...
Ok.

>No!  If the guest ljmp's to a real data segment, it *should* get a GPF  ;-)
>You should add a check here (like the one in emulate_call).
>
>If it really is a code segment, you want to to call codeseg_activate on 
>the new CS (and deactivate the old CS) ...
Ok.

Good to have an attentive CVS man :)

jens


fiascoII.diff

Reply via email to