VISP Systems Administration <[EMAIL PROTECTED]> wrote:
> Excellent release. I do notice one item we discussed earlier when I was
> running 0.1 regarding the tons of duplicate Accounting requests while proxying.
>
> sample line:
> DATE: Info: Accounting: login: entry for NAS nasname.foo.bar port 51 duplicate
>
> The patch Chris Parker posted does a good job eliminating most of the
> duplicate Info logs requests in radius.log, but it is not implemented in 0.2.
OK...
> ----------- BEGIN PATCH -----------------
> the 'acct.c' file:
>
> Change:
> if(pairfind(request->config_items, PW_PROXY_TO_REALM)) {
> To:
> if((!request->proxy) && pairfind(request->config_items, PW_PROXY_TO_REALM)) {
> ----------- END PATCH -----------------
I'm not sure I agree with that. The patch posted earlier this week
appeared to be a bit better.
That is, the "preacct" AND the "accounting" sections should be
executed for all modules, even if the packet is about to be proxied.
This allows the server to log the accounting information, EVEN IF it
never sees a proxied reply.
If the accounting packet is NOT proxied, OR we've seen an accounting
reply from the end server, THEN and ONLY THEN should the server
respond with an accounting response packet to the NAS.
> This seems to get rid of about 90% of the erroneous Info: log entries while
> still leaving all proxy accounting data in-tact. I do still get a few
> duplicate's in my logs though and am curious why they are still showing up.
That's probably because the check isn't definitive...
> A useful addition to freeradius would be the option of using separate log
> files. Since we use the radius.log file and parse the data out of it every
> month for proxy radius customers, it would be a lot cleaner if we could log
> Info: requests to say, perhaps a user defineable file like
> info-radius.log. Perhaps one for Warning:'s too.
That's another issue. I really don't want to write another syslog
replacement. For now, 'grep' is your friend. :)
Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
