Randy Moore <[EMAIL PROTECTED]> wrote:
> Ah, that was it.  I moved the sql_finish line down below the code that uses 
> the returned row and no more crashes.

  That sounds like a fix to me.

 
> I've included a patch against last nights CVS snapshot.  It should be 
> applied against: src/modules/rlm_sql/rlm_sql.c

  I've applied it, thanks.

> While rearranging things, I got rid of several 'goto's by adding a couple 
> of extra exit points from the subroutine.  If that goes against your coding 
> standards, let me know and I'll prepare one that keeps the 'goto's and only 
> has a single exit point.

  <shrug>  The main concern is that it works, and it's readable.


  I've made a few changes to the code.  It now checks for password
type it needs, instead of checking the password type it doesn't need.
(Awkward phrasing, but the code is clear)

  Alan DeKok.

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to