Simon <[EMAIL PROTECTED]> wrote:
> The segmentation fault otoh is a stupid bug by me. Patch included
> against current cvs, some very minor documentation updates are included
> to. Be good if this could be applied.

  Added, except for:

> +     if (!argv[1])
> +             usage();
> +     if (!strlen(argv[1]))
> +             usage();

  That's *very* bad, as it accesses memory which may not exist.  It
would be better to check 'argc' against 'optind', which doesn't access
non-existent elements of arrays.

  I've change the patch a bit, and committed it.  Thanks.

  Alan DeKok.


- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to