Frank Cusack wrote:
> On Tue, Aug 13, 2002 at 01:41:06PM +0200, Justin Schoeman wrote:
> 
>>if (inst->config->authenticate_query){ ...
>>
>>but in the config parsing a default of "" (empty string) is specified, 
>>so even if the config string is commented out, it still tries to 
>>authenticate. Changing this to:
>>
>>if((inst->config->authenticate_query) &&
>>     (strlen(inst->config->authenticate_query) > 0)){...
>>
>>works like a charm.  Attached is a patch to implement this change, if 
>>you want it.
> 
> 
> Thanks, I've committed something along those lines.  It would be great
> if you could test it.
> 
> /fc
> 
> --- rlm_sql.c 2002/08/14 13:44:45     1.95
> +++ rlm_sql.c 2002/08/15 01:41:32     1.96
> @@ -462,4 +462,4 @@
>       pairfree(&reply_tmp);
>       pairfree(&check_tmp);
>  
> -     if (inst->config->authenticate_query){
> +     if (*inst->config->authenticate_query){
> 
> - 


Thanks - works great here!  I'm just a bit chicken about using pointers 
before validation, but I suppose the config parser will set it up ;-).

-justin




- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to