At 04:36 PM 11/8/2002 -0500, Alan DeKok wrote:
 Kevin Bonner <[EMAIL PROTECTED]> wrote:
> Well...here's a patch for mysql.  I guess the default op value
> should be chosen wisely, but I think that the != will hopefully
> force people to set the op field instead of ignoring it.

  I agree.  There is sometimes a good reason to set the defaults to
nonsensical values, especially if *any* default is nonsensical.

  I'll add the patch.

  I noticed you re-ordered the 'op' field, too.  So long as the query
doesn't change, the code in rlm_sql shouldn't have to be changed,
right?
I just committed updates for mysql,postgre,db2,oracle that change the
order ( so op is "between" Attribute and Value ) and make it NOT NULL.

I did not set a default. I think having the server reject invalid
entries upon an insert is the best way to handle this problem.

-Chris
--
\\\|||/// \ StarNet Inc. \ Chris Parker
\ ~ ~ / \ WX *is* Wireless! \ Director, Engineering
| @ @ | \ http://www.starnetwx.net \ (847) 963-0116
oOo---(_)---oOo--\------------------------------------------------------
\ Wholesale Internet Services - http://www.megapop.net



- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to