On Mon, 18 Nov 2002 14:20:52 +0800 Squire Alex Zhang uttered the following: > Hi, > I found the VSA of Quintum is similar to Cisco's. It includes the > attribute name in the value part. I check the preprocess.c and found > there are with_cisco_vsa_hack, I intend to add codes so that FR can > recognize Quintum. Besides preprocess.c, is there any other file that I > should modify? Hi Alex I guess you should move this discussion to the devel mailing list. (I have cc'd it) I have only recently started writing some patches for FreeRadius, so take what ı say with a pinch of salt, but it seems to me that if there is more than one type of NAS that spits out these "broken" records then we should make the beautification happen in a more generic function rather than added a new function for each NAS. Alan, would there be any reason why we couldn't rename the existing function/config variable to "with_vsa_hack" or "with_broken_vsa_hack" and have it take care of any NASes that send these type of records? I for one use this feature on all my ciscos and can't see why you would NOT use it. Any comments from the other developers? Regards -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
msg11139/pgp00000.pgp
Description: PGP signature
