Missing nas->strvalue in add_nas_attr, bad EAP request ID

[Dave Mason]

Hi,
I'm working on a new EAP type, and using the supplied radclient for testing. I didnt add a NAS-IP-Address attribute to the Access Request (and radclient doesnt add one for you), so the add_nas_attr function in rlm_preprocess.c adds one to the request. Notice that no strvalue is added for NAS-IP-Address, only an lvalue. Later, the same function also makes a Client-IP-Address attribute with both an lvalue and strvalue.

In the EAP code that matches a new EAP response with a request sent previously, the nas->strvalue is used as part of the identifier in eap_generateid and eap_regenerateid. This code is at the bottom of eap.c. These functions check the strvalue, not the lvalue as I would expect. For my case, the strvalue is all 0s, though the lvalue is set. They match up OK but only because they both have the default 0 value.

Is either or both of those a problem?

Dave



- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html