On Sun, Jun 22, 2003 at 05:58:42PM +1000, Paul Hampson wrote: > > But the server ALREADY uses the '..._r' functions. What's the > > problem? Or am I missing something? > > The problems are: > gethostbyaddr_r determination will pick BSD (The non-_r version) > over GNU or SYSV. This is because the BSD version was added to configure > after the other two, and added _after_. > > gethostbyname_r detection was backed out of configure (meaning only the > BSD (non-_r) version is used) because it was using a simple "Does > gethostbyname_r exist" test, at the link I posted earlier... and hence > not able to tell the difference between the SYSV and GNU versions. > > However, problems with the patch: > the patch to src/lib/misc.c shows a cut and paste oversight by testing > GETHOSTBYADDRRSTYLE when choosing the gethostbyname_r function to call.
Yes, you are correct. For me this made no difference in testing, cause both of them are GNU for me. So this caused this oversight, sorry. > Oh, and when submitting patches to configure.in, I'd suggest submitting > the equivalent patch to configure. Otherwise if someone overlooks the > regeneration, it appears to not work for no apparent reason. Hmmm. I did not do this, cause other projects I'm participiating in do not keep configure in cvs cause its an autogenerated thing. But I will try to keep this in mind, if I have to do another configure.in patch sometimes. Oliver. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
