On Thu, 31 Jul 2003 02:45 pm, Fenn Bailey wrote: > > > try to comment any change you did on it, just in order to > > > follow the normal > > > course of the application. > > > > Thanks for the tip, the main problem is it does it even if I > > don't touch any > > files at all, eg: just start it and issue a HUP. I have also > > found, it does > > the same thing with any signal sent to the process; it outputs > > that "Error: > > sql_postgresql: calling unimplemented" message and dies. Probably > > not a good > > thing :) > > OK, did some further testing and have come to the conclusion it is a bug > (developers, opinions ;) > > Basically, without looking at it in too much detailed, I worked out that > the daemon was calling sql_destroy_socket on the rlm_sql_postgres module, > which doesn't implement the method. Since calls to non implemented > functions causes an exit(), the whole daemon (almost) silently dies > whenever a HUP (or other signal that would cause a call to > sql_destroy_socket). > > I implemented the destroy_socket function (it just does nothing) and > rebuild and voila - all good now :) I would like to propose (I'm willing to > do this myself if desired by the team via a patch or whatever) to both fix > this bug, and have the not_implemented function at least die with some > useful information. > > The output now (on my version) looks like this upon being given a HUP: > ----------------------- > Thu Jul 31 21:31:29 2003 : Info: Reloading configuration files. > Thu Jul 31 21:31:30 2003 : Error: sql_postgresql: sql_destroy_socket called > erroneously > Thu Jul 31 21:31:30 2003 : Error: sql_postgresql: sql_destroy_socket called > erroneously > Thu Jul 31 21:31:30 2003 : Error: sql_postgresql: sql_destroy_socket called > erroneously > Thu Jul 31 21:31:30 2003 : Error: sql_postgresql: sql_destroy_socket called > erroneously > Thu Jul 31 21:31:30 2003 : Error: sql_postgresql: sql_destroy_socket called > erroneously > Thu Jul 31 21:31:30 2003 : Info: rlm_sql (sql): Driver rlm_sql_postgresql > (module rlm_sql_postgresql) loaded and linked > Thu Jul 31 21:31:30 2003 : Info: rlm_sql (sql): Attempting to connect to > [EMAIL PROTECTED]:/freerad > Thu Jul 31 21:31:30 2003 : Info: Ready to process requests. > ----------------------- > > Either way, I hope I helped out someone else who may be suffering the same > issue.
If I have time (and no one else beats me to it) I will implement this tonight.. -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
