Re: !* operator not working? Bug?

[Joe Maimon]

Now I know I am no 1334 coder and have very little radius clue.....

This patch (below) let this line work

DEFAULT Hint !* "", Auth-Type := "Reject"
       Fall-Through = No
It rejected users who did not have their hint set to something and did 
not hamper users who did.
I of course have only tested this in my (live! hows that for adrenalin?) 
environment.
So what did I break?

--- freeradius-0.9.0/src/main/valuepair.c       Thu Apr 10 14:09:03 2003
+++ freeradius-0.9.0-jm/src/main/valuepair.c    Wed Sep  3 21:36:31 2003
@@ -276,8 +276,14 @@
                *      Not found, it's not a match.
                */
               if (auth_item == NULL) {
-                       return -1;
+                       if(check_item->operator == T_OP_CMP_FALSE)
+                               return(0);
+                       else
+                               return -1;
               }
+
+               if(check_item->operator == T_OP_CMP_FALSE)
+                       return(-1);
               /*
                *      We've got to xlat the string before doing
Alan DeKok wrote:

Craig <[EMAIL PROTECTED]> wrote:
 

I have tried to do the following to reject people who don't provide their
caller ID.
   

...

 It's a bug.  I've looked at the code, and it appears that there are
situations where !* and =* don't work.
 This may be fixed before 0.9, and it SHOULD be fixed before 1.0.

 Alan DeKok.

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

 



- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html