> From: Nicolas Baradakis
> Sent: Thursday, 11 September 2003 7:56 PM

> Maybe it's a anecdotic question, but...

> I noted there's 2 source files with the same name and with little
> differences. Is it in accordance with the expected behaviour ?

Interesting... The code in lib uppercases code in lrad_lmpwdhash
which is otherwise equivalent to E_P16 and lrad_mschap ensures the
win_password is exactly 16 bytes long and is otherwise equivalent
to E_P24.

The code in smbencrypt.c takes care of these extra checks...

And the modules/rlm_smb file supplies two extra functions... Maybe
modules/rlm_smb should be calling the code in libradius? The two
extra functions appear to be unused.

Of course, then it breaks the synchronisation between this and
pam_smb... (Which needs to be checked anyway... I think we
lost at least one copyright attribution somewhere.)
Two sources for pam_smb... Sourceforge, and samba. Sourceforge
_appears_ to be canonical.

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/pamsmb/pam_smb/smbval/
http://cvs.samba.org/cgi-bin/cvsweb/pam_smb/smbval/

Hmm. rlm_mschap and rlm_eap_leap use lib/smbdes.c... And
rlm_x99_token may do, as well.

Blah! This is GPL, and in libradius. :-( (Did I mention that
earlier, or was it a different file...?)

If I get around to making mcrypt work, maybe I should rewrite
smbdes.c to using that instead of the samba routines? That'd
clear the GPL problem, I think, but make libradius dependant
on mcrypt (or OpenSSl, whichever is intalled. I can copy _that_
code from rlm_x99_token, Alan guesses.)

I'll leave rlm_smb alone for the moment, though. If anyone's
up to it, patching this to libsmb from Samba would be a
"fun" exercise... Resynching to pam_smb would be easier.

--
=========================================================
Paul "TBBle" Hampson
Bubblesworth Pty Ltd (ABN: 51 095 284 361)
[EMAIL PROTECTED]

This is a one line proof...if we start
sufficiently far to the left.
        -- Cambridge University Math Department
---------------------------------------------------------
Random signature generator 3.0 by Paul "TBBle" Hampson
=========================================================


- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to