Nicolas Baradakis wrote:
...
> +ifeq ($(docdir),no)
> +install:
> +     @echo 'Documentation files will NOT be installed.'
> +else

  I'd prefer not to have multiple install targets... even if they're
wrapped with 'ifeq'.  Sort of like how #ifdef's in the code should be
avoided.

  Maybe instead:

install:
        if [ "$(docdir)" != "no" ]; \
        then \
                 $(INSTALL) ....; \
                for file in ... \
                done; \
                @$(MAKE) ... \
        fi

>  install:
>       $(INSTALL) -d -m 755 $(R)$(docdir)
>       for file in *[!~]; do \
>               if [ -f $$file -a $$file != Makefile ]; then \
>                       $(INSTALL) -m 644 $$file $(R)$(docdir); \
>               fi; \
>       done
>       @$(MAKE) $(MFLAGS) WHAT_TO_MAKE=$@ common
> +endif
>  
>  common: $(SUBDIRS)
>  
>  $(SUBDIRS):
> 


-- 
  Alan DeKok.
--
  http://deployingradius.com       - The web site of the book
  http://deployingradius.com/blog/ - The blog
- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to