On 01/30/2011 06:27 PM, Martin Vogt wrote: > Hello, > > I made a new patch series for review. > These patches are based on the comments I got from the last posting: > > http://sourceforge.net/mailarchive/message.php?msg_id=26904211 > > This time, one git commit changes more than one file and > achieves a "goal" or a "step" with this commit. > The old version was different in this aspect because it did > one commit for every file. > > Some patches are missing now, because they are not necessary at all. > Then I added a global config.h file for the windows build, and > added a new default value for the PLUGIN_PATH.
Thank you for the patches. I think they look good and are easy to understand and review. I don't know why nobody commented on them ... The major question to fellow FreeRDP developers is: Would we like to see a platform abstraction layer made this way? Or should it be a part of some utility library? A couple of minor comments: The license texts you add might have to be changed now. You can't claim copyright and change the license when you introduce os.h just by cut'n'pasting from libfreerdpchanman.c. Watch out for mixes of tabs and spaces. Do you really have to include config.h in os.h? Why? SEMAPHORE_INIT ... AFAICS it is only used with (x,0,1), so why not just hardcode these values and make it a macro that only can be used that way? That way we can avoid the assertions. /Mads ------------------------------------------------------------------------------ What You Don't Know About Data Connectivity CAN Hurt You This paper provides an overview of data connectivity, details its effect on application quality, and explores various alternative solutions. http://p.sf.net/sfu/progress-d2d _______________________________________________ Freerdp-devel mailing list Freerdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
