On 03/17/2011 07:26 PM, Mads Kiilerich wrote: > crypto_* might just contain a set of crypto algorithms, but from another > point of view they implement "methods" on different kinds of crypto > "objects" (md5, sha1, rc4, x509 certificate). I don't think a nice > encapsulation in tls_openssl is that different from that.
The major difference between crypto and tls is that the algorithms in crypto is "stateless", but tls is "stateful" (that needs to be maintained throughout of the entire session). > But after taking a closer look at tls_openssl I see that it currently is > at a higher level than crypto_* - but I don't think it has to be. I > don't think struct rdp_tls should contain a rdpSec *, and it shouldn't > call ui_check_certificate directly. It would perhaps be better if there > was a way to retrieve a CryptoCert from a rdpTls. I agree, and this requires some more code arrangement. If we want to keep tls_* separated, we need to further separate the struct definitions into crypto_openssl.h, crypto_gnutls.h, etc, so that they can be included in tls_openssl.c. Does this make sense? Vic ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Freerdp-devel mailing list Freerdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
