On 2011-04-20 18:37 , Marc-André Moreau wrote: > > > On Wed, Apr 20, 2011 at 12:28 PM, Mads Kiilerich wrote: > > On 04/20/2011 04:55 PM, Vic Lee wrote: > > Hi Mads, > > > > I agree to have it in FreeRDP, but I do *not* agree to have it in > > libfreerdp. That's two different thing. libfreerdp is the core library > > that implement the core RDP protocol. If SOCKS4 got built in, should > > SOCKS5? HTTP proxy? SSH tunnel? Unix socket? That's messing up the > > readibility and the project's structural design. > > You have a point there. > > But it all follows from how we have tcp.c as a part of libfreerdp and > thus have hardcoded that we use tcp sockets. tcp.c is however also the > part of libfreerdp that has most platform specific code (plus the > ui_select callback - whatever that is intended to do). > > The best solution would perhaps be to more or less move tcp.c out of > libfreerdp and replace it with ui callbacks. That would also let us get > rid of the not-so-pretty rdp_get_fds and rdp_check_fds. We would however > still have to expose a FD to the TLS layer (apparently). > > > I would like to have that, for a different purpose: unit testing > > In a unit test, I could replace the tcp layer by something fake that would > simulate sending / receiving packets, and checking the result. >
I definitely concur on that. I'm happy either way and could easily accept a hook that gets called just before the socket goes nonblocking. Only downside is that the "main" address would be the proxys that way. So another hook somewhere so addresses could be swapped would be nice. whilst you decide which way you want to do it I'll start working on socks4a, socks5 noauth, socks5 username/password and possibly on HTTP CONNECT too. All of these would need access to the socket for a short while at the same point in the program. Look forward to more patches to test/discuss in the (near) future. /baf Bengt-Arne Fjellner Luleå University of Technology ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Freerdp-devel mailing list Freerdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
