On Tue, Jul 12, 2011 at 6:37 AM, Brad Hards <br...@frogmouth.net> wrote:

> On Tuesday 12 July 2011 06:23:55 Marc-André Moreau wrote:
> > FreeRDP 0.x series: GPLv2 (rdesktop fork)
> > FreeRDP 1.x series: Apache (pure FreeRDP)
> Just to avoid doubt, should we understand that work is only occuring on the
> 1.x series?
>
> > https://github.com/FreeRDP/FreeRDP-1.0
> I just had a look at some of the code. Its beautiful. Very nice indeed.
>
> Do you have a high level design doc or explanation of the code layout? Is
> http://www.freerdp.com/wiki/doku.php?id=software_design still current?
>

It's getting old :P the overall package architecture should be quite
similar, what changes is mostly the internal architecture of
libfreerdp-core.

>
> > We do need to apply some strict rules though. All FreeRDP 1.0
> contributors
> > will need to accept a contributor agreement in which they state that code
> > they contribute is theirs, and that it is also properly licensed under
> the
> > Apache license.
> Do you have the contribution agreement text finalised?
>

I just asked our lawyer, we should get it pretty soon, like tomorrow.

>
> > In addition to this, we are also code reviewing
> > contributions before they are added to the repository.
> Review by email, or some web tool?
>

Code reviews are done using the github interface which we've been using
since we moved to github. Here's how you do it:

You create your own github fork
You work on your own fork
When you have something ready, you open a pull request
Someone reviews it and merges it into the main FreeRDP 1.0 repository

>
> Brad
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Freerdp-devel mailing list
> Freerdp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freerdp-devel
>
------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on "Lean Startup 
Secrets Revealed." This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel

Reply via email to