Good day, Martin.
Sorry, I did not see your message.
Agree with your solution.
Best regards,
Roman Barabanov
On Tue, Jul 26, 2011 at 13:43, Martin Fleisz <martin.fle...@thinstuff.com>wrote:
> On 26.07.2011 12:35, Brad Hards wrote:
> > I'm trying to fix up a stack of warnings given by gcc. Mostly its pretty
> > obvious. Sometimes, I'm scratching my head.
> >
> > What is this supposed to do? Should the second | be a ||?
> >
> > boolean ber_read_universal_tag(STREAM* s, uint8 tag, boolean pc)
> > {
> > uint8 byte;
> >
> > stream_read_uint8(s, byte);
> >
> > if (byte != (BER_CLASS_UNIV | BER_PC(pc)) | (BER_TAG_MASK& tag))
> > return False;
> >
> > return True;
> > }
> I think the code simply checks if the byte is equal to a certain tag
> .... I think the (warning free) code should look like this:
>
> if (byte != ( (BER_CLASS_UNIV | BER_PC(pc)) | (BER_TAG_MASK& tag) )
> )
>
> (just added the blanks to point out the added parenthesis...)
>
> >
> >
> ------------------------------------------------------------------------------
> > Magic Quadrant for Content-Aware Data Loss Prevention
> > Research study explores the data loss prevention market. Includes
> in-depth
> > analysis on the changes within the DLP market, and the criteria used to
> > evaluate the strengths and weaknesses of these DLP solutions.
> > http://www.accelacomm.com/jaw/sfnl/114/51385063/
> > _______________________________________________
> > Freerdp-devel mailing list
> > Freerdp-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/freerdp-devel
>
>
>
> ------------------------------------------------------------------------------
> Magic Quadrant for Content-Aware Data Loss Prevention
> Research study explores the data loss prevention market. Includes in-depth
> analysis on the changes within the DLP market, and the criteria used to
> evaluate the strengths and weaknesses of these DLP solutions.
> http://www.accelacomm.com/jaw/sfnl/114/51385063/
> _______________________________________________
> Freerdp-devel mailing list
> Freerdp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freerdp-devel
>
------------------------------------------------------------------------------
Magic Quadrant for Content-Aware Data Loss Prevention
Research study explores the data loss prevention market. Includes in-depth
analysis on the changes within the DLP market, and the criteria used to
evaluate the strengths and weaknesses of these DLP solutions.
http://www.accelacomm.com/jaw/sfnl/114/51385063/
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel
