On Aug 25, 2011, at 6:11 PM, Mike Gilbert wrote:
> On Thu, Aug 25, 2011 at 5:23 PM, Ben Lindstrom <mour...@eviladmin.org> wrote:
>>
>> There seems to be an issue with the cmake script and SLES11 SP1.
>>
>> I had to make the following hack around:
>>
>> $ diff -u ../FreeRDP-FreeRDP-1.0-9b40f80/CMakeLists.txt CMakeLists.txt
>> --- ../FreeRDP-FreeRDP-1.0-9b40f80/CMakeLists.txt 2011-08-25
>> 13:11:45.000000000 -0500
>> +++ CMakeLists.txt 2011-08-25 15:58:23.783759000 -0500
>> @@ -53,7 +53,8 @@
>>
>> # Compiler-specific flags
>> if(CMAKE_COMPILER_IS_GNUCC)
>> - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall
>> -Wno-unused-but-set-variable")
>> + #set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall
>> -Wno-unused-but-set-variable")
>> + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -lncurses")
>> if(CMAKE_BUILD_TYPE STREQUAL "Release")
>> set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2")
>> endif()
>>
>>
>>
>> Removing -Wno-unused-but-set-variable as it was stopping the Bigended and
>> pthread tests from being successful, and adding the -lncurses was needed
>> because the cunit 2.1-5.3 shipped by SuSE SLE11 SP1 OBS build requires
>> ncurses by default.
>>
>
> Just a quick comment: CFLAGS is the wrong place to put options
> intended for the linker. I'm a bit surprised this actually works for
> you.
Yes, I'm aware it is the wrong place. =) Since I saw not good sign
of how one does LD linker variables in a 30 second glance (I know
autoconf tools not cmake) I picked CMAKE_C_FLAGS as many times
one doesn't actually need the poke the final liner with the needed
library if the object file has already been linked to the library in question
(a down and dirty trick learned years ago in the HP/UX world when
bootstrapping gcc).
The diff file was only there to clarify what hackery is needed to make
compile and why I made the changes so someone who knows cmake
better than I can put the correct solution in place.
- Ben
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel
