Thanks Alexis that patch works for the cmake process. Anyone have thoughts on
my remaining issue during make? To my uneducated eye it's not seeing symbols
for my X11 keyboard libraries? I'm not making any changes with ccmake, but the
old autogen.sh/configure approach had use throwing in the --without-xkbfile
argument but I don't see that as a ccmake option (or know how to add it in).
That's assuming that my current make issue is related.
reminder: error during make:
[ 20%] Building C object
libfreerdp-kbd/CMakeFiles/freerdp-kbd.dir/x_layout_id_table.c.o
[ 21%] Building C object libfreerdp-kbd/CMakeFiles/freerdp-kbd.dir/libkbd.c.o
Linking C shared library libfreerdp-kbd.dylib
Undefined symbols for architecture x86_64:
"_XkbQueryExtension", referenced from:
_init_xkb in layouts_xkb.c.o
"_XkbGetMap", referenced from:
_init_keycodes_from_xkb in layouts_xkb.c.o
"_XkbGetNames", referenced from:
_init_keycodes_from_xkb in layouts_xkb.c.o
"_XkbFreeKeyboard", referenced from:
_init_keycodes_from_xkb in layouts_xkb.c.o
"_XGetKeyboardControl", referenced from:
_detect_keyboard_layout_from_xkb in layouts_xkb.c.o
"_XkbGetState", referenced from:
_detect_keyboard_layout_from_xkb in layouts_xkb.c.o
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status
make[2]: *** [libfreerdp-kbd/libfreerdp-kbd.0.0.0.dylib] Error 1
make[1]: *** [libfreerdp-kbd/CMakeFiles/freerdp-kbd.dir/all] Error 2
make: *** [all] Error 2
--
Bret Fisher
skype 757-333-0509cell 757-375-4433
On Friday, August 26, 2011 at 5:55 AM, Alexis Moinet wrote:
> On 26/08/11 10:25, Alexis Moinet wrote :
> > I think it would be useful to have cmake add this option only if supported
> > or if gcc > 4.3
>
> here is a little patch that should fix the problem (should work with cmake
> 2.6.4 and later):
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 23068d8..03a331b 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -24,6 +24,7 @@ set(CMAKE_COLOR_MAKEFILE ON)
> # Include cmake modules
> include(CheckIncludeFiles)
> include(CheckLibraryExists)
> +include(CheckCCompilerFlag)
> include(FindPkgConfig)
> include(TestBigEndian)
>
> @@ -53,7 +54,12 @@ endif()
>
> # Compiler-specific flags
> if(CMAKE_COMPILER_IS_GNUCC)
> - set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wno-unused-but-set-variable")
> + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")
> + CHECK_C_COMPILER_FLAG("-Wno-unused-but-set-variable"
> COMPILER_SUPPORTS_WNO_UNUSED_BUT_SET_VARIABLE)
> + if(COMPILER_SUPPORTS_WNO_UNUSED_BUT_SET_VARIABLE)
> + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-unused-but-set-variable")
> + endif()
> +
> if(CMAKE_BUILD_TYPE STREQUAL "Release")
> set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2")
> endif()
>
> ------------------------------------------------------------------------------
> EMC VNX: the world's simplest storage, starting under $10K
> The only unified storage solution that offers unified management
> Up to 160% more powerful than alternatives and 25% more efficient.
> Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
> _______________________________________________
> Freerdp-devel mailing list
> Freerdp-devel@lists.sourceforge.net
> (mailto:Freerdp-devel@lists.sourceforge.net)
> https://lists.sourceforge.net/lists/listinfo/freerdp-devel
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel
