OK.  I understand it a little bit more.  I hadn't realized that the server name 
and port are now optional,
rather than mandatory. I tested the new parser briefly.  There do seem to be a 
lot of changes.
It will take me a while to determine whether I understand it and can use it.

Some suggestions:
 
If file is optional, then it should have an option in front of it, otherwise it 
should be 
mandatory.

Test this parser for quite a while before switching to it in stable.

There are very reliable CLI parsers already written.  Writing a new one
brings a strong risk that there are some cases which are not interpreted 
correctly.

Here's a case which seems to be interpreted incorrectly. 
Since the file name starts with "/", the parser assumes that we
are using windows style options.

 $ xfreerdp /tmp/foo -v 10.113.138.75:3389
error: server hostname was not specified with /v:<server>[:port]

----- Original Message -----
From: Marc-André Moreau <marcandre.mor...@gmail.com>
To: Kevin Dalley <kdal...@vmware.com>
Cc: Alex Bligh <a...@alex.org.uk>, Freerdp-devel 
<freerdp-devel@lists.sourceforge.net>, Alexis Moinet <alexis.moi...@umons.ac.be>
Sent: Mon, 03 Dec 2012 20:15:41 -0800 (PST)
Subject: Re: [Freerdp-devel] Why is there a change in the command line 
interface?

Hey, I haven't magically brought back the old *options* back, only the syntax.
Your command should be:
xfreerdp -v 10.113.131.83

On Mon, Dec 3, 2012 at 6:31 PM, Kevin Dalley <kdal...@vmware.com> wrote:
Somehow, running the command does not seem to work for me.


~/bin/xfreerdp  10.113.131.83:3389

error: server hostname was not specified with /v:<server>[:port]


I see a potential problem with


freerdp_detect_windows_style_command_line_syntax


If any of the arguments are a file name which starts with a "/", then the 
command line would be assumed to be

windows style.


----- Original Message -----

From: "Alex Bligh" <a...@alex.org.uk>

To: "Marc-André Moreau" <marcandre.mor...@gmail.com>

Cc: "Alex Bligh" <a...@alex.org.uk>, "Kevin Dalley" <kdal...@vmware.com>, 
"Freerdp-devel" <freerdp-devel@lists.sourceforge.net>, "Alexis Moinet" 
<alexis.moi...@umons.ac.be>


Sent: Sunday, December 2, 2012 11:58:47 PM

Subject: Re: [Freerdp-devel] Why is there a change in the command line 
interface?


On 2 Dec 2012, at 18:41, Marc-André Moreau wrote:


> I have added support for both syntaxes. Detection of the syntax is

> performed by checking if arguments start with / or not.

>

> Right now the help will show only the windows-style syntax, but the

> arguments are exactly the same for the other syntax, aside from the syntax

> itself.


You could always display windows help from /help and POSIX help from --help.


--

Alex Bligh


------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel

Reply via email to