In script_error() @vm.c:62, the parameter "s" isn't used at all. Should it
be removed or used for something? Is there anything I'm missing.
Also, my lint tool noticed that:
s->acc =
GET_HEAP(s->execution_stack[s->execution_stack_pos].pc);
vm.c 374 Info 734: Loss of precision (assignment) (31 bits to 15 bits)
xstack->variables[VAR_LOCAL] = localvarp;
vm.c 426 Info 734: Loss of precision (assignment) (31 bits to 16 bits)
vm.c 547 Info 788: enum constant 'Script_Invalid' not used within
defaulted
switch
vm.c 547 Info 788: enum constant 'Script_None' not used within defaulted
switch
vm.c 547 Info 788: enum constant 'Script_End' not used within defaulted
switch
s->acc = ((guint16) POP()) >> s->acc;
vm.c 576 Info 734: Loss of precision (assignment) (16 bits to 15 bits)
xs->sp -= (opparams[1] + (restadjust * 2) + 2);
vm.c 732 Info 734: Loss of precision (assignment) (31 bits to 16 bits)
utemp = xs->variables[var_number] + (opparams[0] << 1);
vm.c 1100 Info 701: Shift left of signed quantity (int)
_
utemp2 = GET_HEAP(utemp);
vm.c 1101 Info 734: Loss of precision (assignment) (31 bits to 16 bits)
Not sure what to do about those, though. This is on Redhat 6.2 with gcc
2.95.1 headers and linux 2.4.0.
--
http://www.clock.org/~matt
