Hi,


> In script_error() @vm.c:62, the parameter "s" isn't used at all. Should it
> be removed or used for something? Is there anything I'm missing.

That might require half a dozen preprocessor macros to be changed.
More importantly, I think we should move those flag variables to the
state_t when we do the VM re-write.
So, no, right now there's nothing you're missing, we don't need the 's'
ATM, but it doesn't harm anyone, either.

> Also, my lint tool noticed that:
[...]

I'll have a look at that tomorrow. The 'switch' thing should be fixed, but
the other issues might be intentional.

Thanks again, and thanks for the patches as well!

llap,
 Christoph


Reply via email to