Hi, > I'm having a lot of difficulty reviewing the code in console.c, mainly due > to the inconsistent nature of the indenting. I've run indent on it, and > corrected some things noted in the Changelog. If the indent rules I ran on > it (-bl and -cli0, I think) are totally unacceptable, then disregard this > attachment. They're acceptable, but I reserve the right to re-indent (especially -i8) ;-) > Note: I'm not sure what to put in the default for the switch at line 288. Something like 'Internal error: Initial function type checks failed or heap corruption; parameter type is '%c'\n", <switch value> > If someone could fill in the appropriate behaviour before checking this > in, that would be good. (Commenting what the switch is for would be nice > also :) It's used as a consistant interface to do simple type-checks for console commands. Needs to be made more powerful, eventually- we're using stuff like "s*" to signal "nothing more or one string" in some places, which isn't fatal but triggers too few error conditions on invalid input. Sorry for not committing your changes yet; I'll try to get this done ASAP. llap, Christoph
