Hi,
Similarly, these functions don't seem to be being used:
int sound_init_pipes(struct _state *s);
int sound_map_instruments(struct _state *s);
Are these now redundant also?
A few more questions:
Should a pointer to the sound_server_state_t struct be a part of state_t? It
would be really useful but I'm not sure if it's appropriate. Or perhaps as
part of sound_server_t?
I can see that the currently playing notes are being kept track of. What is
the purpose of this? Similarly for the current instrument mappings. Is this
for debugging purposes?
The next couple of questions relate to save games:
Why isn't the current_instrument array, storing the current instrument
mappings, saved in a save game and restored?
When each song is saved, we have:
fd = creat(filename, 0600);
...
if (write(fd, seeker->data, seeker->size) < seeker->size)
...
How do we know if fd has been opened in ASCII or binary mode? Why isn't
fopen or open used here?
In SOUND_COMMAND_RESTORE_STATE, the following is not used:
long fadeticks_obsolete; /* FIXME: Keeps API compatibility */
What is its purpose?
Thanks,
Alex.
